Duy Nguyen <pclouds@xxxxxxxxx> writes: > On Fri, Aug 9, 2013 at 1:12 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> When we see a recent lockfile created by a "gc" running elsewhere, >> we do not set "should_exit". Is that a good thing? I am wondering >> if the last two lines should be: >> >> - !strcmp(locking_host, my_host) && >> - !kill(pid, 0); >> + (strcmp(locking_host, my_host) || !kill(pid, 0)); >> >> instead. > > Yes I think it should (we still have the 12-hour check to override > stale locks anyway). Should I send another patch or you do it yourself > (seeing that you have this chunk pasted here, you might have it saved > somewhere already) The above was typed in my MUA ;-), but it is an easy update I can do so will do so anyway. Thanks for double-checking. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html