On 08/07/2013 06:00 PM, Ramkumar Ramachandra wrote:
> Hi,
>
> This is the difference between whatchanged and log:
>
> diff --git a/whatchanged b/log
> index fa1b223..004d9aa 100644
> --- a/tmp/whatchanged
> +++ b/tmp/log
> @@ -1,4 +1,4 @@
> -int cmd_whatchanged(int argc, const char **argv, const char *prefix)
> +int cmd_log(int argc, const char **argv, const char *prefix)
> {
> struct rev_info rev;
> struct setup_revision_opt opt;
> @@ -7,13 +7,10 @@ int cmd_whatchanged(int argc, const char **argv,
> const char *prefix)
> git_config(git_log_config, NULL);
>
> init_revisions(&rev, prefix);
> - rev.diff = 1;
> - rev.simplify_history = 0;
> + rev.always_show_header = 1;
> memset(&opt, 0, sizeof(opt));
> opt.def = "HEAD";
> opt.revarg_opt = REVARG_COMMITTISH;
> cmd_log_init(argc, argv, prefix, &rev, &opt);
> - if (!rev.diffopt.output_format)
> - rev.diffopt.output_format = DIFF_FORMAT_RAW;
> return cmd_log_walk(&rev);
> }
>
> Should we remove it?
I'd deprecate it first for a year or such and remove it then.
In the meantime we could implement already remove the code
and change it to:
+ int cmd_whatchanged(int argc, const char **argv, const char *prefix)
+ {
+ return cmd_log(argc, argv, prefix)
+ }
Also we should make sure everything git whatchanged can do,
can easily be done with git log <options>.
Stefan
Attachment:
signature.asc
Description: OpenPGP digital signature