As a follow-up to Stefan's series, we may want to think about the following as well: - OPT__VERBOSE() is defined in terms of OPT_BOOLEAN(). I think we use it to represent increasing levels of verbosity, so we cannot turn this into OPT_BOOL(). Its implementation has to become OPT_COUNTUP(). - OPT__QUIET() is defined in terms of OPT_BOOLEAN(). I offhand do not know if we have increasing levels of quietness. The users need auditing before we can decide to turn this into either OPT_COUNTUP() or OPT_BOOL(). - OPT__DRY_RUN() should probably become OPT_BOOL(). - OPT_FORCE(); do we have levels of forcefulness? If so OPT_COUNTUP(), otherwise OPT_BOOL(). And here is my attempt. The last one is iffy as I didn't bother auditing the existing callers. Junio C Hamano (4): OPT__QUIET(): switch from count-up to true bool OPT__VERBOSE(): clarify its expected use by using OPT_COUNTUP OPT__DRY_RUN(): use OPT_BOOL, not OPT_BOOLEAN OPT__FORCE(): clarify its expected use by using OPT_COUNTUP parse-options.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 1.8.4-rc1-210-gf6d87e2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html