On Sat, Aug 3, 2013 at 1:33 PM, Fredrik Gustafsson <iveqy@xxxxxxxxx> wrote: > On Fri, Aug 02, 2013 at 09:10:59PM +0700, Duy Nguyen wrote: >> > So my question is, how you'd generally approach rewriting a >> > shell script in C. >> >> Start a new process via start_command/run_command interface. It's >> safer to retain the process boundary at this stage. You can try to >> integrate further later. > > Is it really the right approach to just replace sh with C? IMHO forking > and wait for the result should not be done if it can be avoided. It just > adds overhead. Agreed. As I said in another post, I misread this as rewriting git-rebase.sh, which is a lot more complicated. > Of course you can argue that just replace sh with C is a good first step > towards to actually do the command in "full C". Altough I'm afraid that > that will get such low priority that it won't be done. One of the reasons I started porting git-repack.sh since 2011 and never finished it. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html