Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > While going through the for-each-ref-pretty series that Duy and I were > developing, I noticed that this cleanup was independent and good > as-it-is. > > So here it is. You always can first allocate a piece of memory and write into it instead of writing things out directly. The patch shows it _can_ be done, but that is not a news. And such a change is hardly a "clean-up". It just wastes more memory you do not have to waste, in order to do what you are doing. When there is a reason why you need an in-memory representation, this change starts to become the first step refactoring for an enhancement. > Nguyễn Thái Ngọc Duy (1): > for-each-ref, quote: convert *_quote_print -> *_quote_buf The log message for this one explains it very well. This change by itself is not useful, but it will become necessary once you start needing to access an in-memory result. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html