David Aguilar <davvid@xxxxxxxxx> writes: > diff --git a/imap-send.c b/imap-send.c > index d6b65e2..3fd9c0e 100644 > --- a/imap-send.c > +++ b/imap-send.c > @@ -22,14 +22,11 @@ > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > */ > > -#include "cache.h" > -#include "exec_cmd.h" > -#include "run-command.h" > -#include "prompt.h" > #ifdef NO_OPENSSL > typedef void *SSL; > #else > #ifdef APPLE_COMMON_CRYPTO > +/* git-compat-util.h overwrites ctype.h; this must be included first */ I do not like this part of the patch, for the exact reason Jonathan already mentioned. The concern this comment addresses is exactly the kind of thing git-compat-util.h was introduced for. Could we keep the encapsulation of the logic to decide what to include and in what order in git-compat-util.h, please? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html