Mark Levedahl wrote:
> The supported Cygwin distribution on supported Windows versions provides
> complete support for POSIX filemodes, so enable this by default. git as
> distributed by the Cygwin project is configured this way.
>
> This fixes one testsuite failure:
> t3300 test 17 (diff-index -M -p with mode change quotes funny filename)
>
> Historical notes: Cygwin version 1.7 supports Windows-XP and newer, thus
> dropped support for all OS variants that lack NTFS and/or the full win32
> api, and since late 1.5 development, Cygwin maps POSIX modes to NTFS ACLs
> by default. Cygwin 1.5 supported OS variants that used FAT as the native
> file system, and had optional methods for providing POSIX file modes on
> top of FAT12/16 and NTFS, though not FAT32. Also, support for POSIX modes
> on top of FAT were dropped later in 1.5. Thus, POSIX filemode support
> could not be expected by default on a Cygwin 1.5 installation, but is
> expected by default on a 1.7 installation.
>
> Signed-off-by: Mark Levedahl <mlevedahl@xxxxxxxxx>
> ---
> Junio - The above notes are more accurate than in my previous commit message,
> so if this commit survives into next/master, I would prefer this version as
> opposed to the one now on pu (da875762)
Again, I have to ask; should you not "revert" commit c869753e ("Force core.filemode
to false on Cygwin.", 30-12-2006)? After this commit, there is no longer any user
of the NO_TRUSTABLE_FILEMODE build variable, and no real prospect of anyone else
wanting to use it.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html