On Thu, Jul 18, 2013 at 09:02:12PM +0100, Ramsay Jones wrote: > The sentinel function attribute is not understood by versions of > the gcc compiler prior to v4.0. At present, for earlier versions > of gcc, the build issues 108 warnings related to the unknown > attribute. In order to suppress the warnings, we conditionally > define the GIT_SENTINEL macro to provide the sentinel attribute > for gcc v4.0 and newer. > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> > --- Acked-by: Jeff King <peff@xxxxxxxx> > -__attribute__((sentinel)) > +GIT_SENTINEL(0) > void argv_array_pushl(struct argv_array *, ...); We could also add GIT_SENTINEL to handle the default-zero case, but I do not think it is worth the trouble. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html