Re: [PATCH] diff --check: use colour

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 26, 2007 at 10:06:54AM -0600, Bill Lear wrote:

> git format-patch -s HEAD^
> [...]
> which looks to be formatted as a mail message:

Right.

The format is:
  - subject line is the first line of your commit message
  - subsequent body lines are the rest of your commit message, until you
    hit the ---
  - below that is the patch; everything in the patch section that is not
    an actual diff hunk is free-form (e.g., the diffstat).

> Do I optionally edit this file, putting my comments before the
> "Signed-off-by" line, and then just send this off to the list with my
> mail command, i.e.:

Comments before the signed-off-by line will be part of the commit
message; so if you have comments to put there, you probably would have
made them when your were committing. If you have comments to send with
the email ("cover letter"), place them after the --- but before the
diffstat.

> % mail git@xxxxxxxxxxxxxxx < 0001-Document-check-option-to-git-diff.patch
> 
> ?

I'm not an expert on 'mail' but I'm not sure if it handles headers
correctly (i.e., it expects body text, _not_ the full rfc822 message).
You can use git-send-email, but I find its interface a little clunky.
You can use git-imap-send to place the message in an IMAP mailbox, which
you can then presumably grab as a 'draft' using your regular mail
client. Or you can use a mail client which understands mbox (most unix
ones do), open the file as an mbox, and then resume it as a draft.

Or finally, you can simply edit in the headers you want, remove the
initial 'From ' line, and pipe it to sendmail. :)

What's easiest for you depends on what your mail setup is like (I use
mutt to open the mbox, then "resend" it with editing).

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]