On Fri, Jul 12, 2013 at 2:34 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
>
>> ... Is it desirable to do so
>> or should the user have more fine-grained control? ("xargs -0" comes
>> to mind when thinking of a null-termination input switch.)
>
> For the purposes of check-attr and check-ignore, a single "-z"
> governing both is sufficient. I think you already got that from my
> 4-patch series, but the core reason for that is :
I'm reading it right now.
> - when "-z" is used, the user knows the input paths may need
> protection against LF.
>
> - our output contains these same paths.
>
> - which means our output cannot be expressed unambiguously using LF
> as record separator.
>
> For the purpose of check-mailmap, I actually do not see much point
> in supporting "-z" format. We do not even handle names or addresses
> with LF in it. The mailmap format would not let you express such
> records in the first place, no?
You're right. I had this exact argument in mind for why
null-termination was not needed on the input side of check-mailmap,
but for some reason I had a blind spot concerning the output side.
I'll drop this option in the next re-roll.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html