Jeff King <peff@xxxxxxxx> writes: > On Mon, Jul 08, 2013 at 02:09:59PM -0700, Junio C Hamano wrote: > >> The definition of "struct ref" in "cache.h", a header file so >> central to the system, always confused me. This structure is not >> about the local ref used by sha1-name API to name local objects. >> [...] >> * I hate to to this kind of code-movement in the middle of the >> cycle, but every time I follow the push->transport codepath, I >> become disoriented by these "struct ref"s. > > FWIW, this has often bugged me, too. I did not check what fallouts this > will have for series in flight, but in general, I think it is a good > thing to be doing. The fallout can be seen at the tip of 'pu', which is fairly minimum at the moment. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html