On Fri, Jul 05, 2013 at 01:11:49AM -0700, Junio C Hamano wrote: > Alexey Shumkin <alex.crezoff@xxxxxxxxx> writes: > > >> Both "iso8859-1" and "iso-8859-1" are understood as latin-1 > >> by modern platforms, but the latter is not understood by > >> older platforms;update tests to use the former. > >> > >> This is in line with 3994e8a9 (t4201: use ISO8859-1 rather > >> than ISO-8859-1, 2009-12-03), which did the same. > > Yep, it whould be better, I thought to do like this but I didn't ) > >> > >> > Signed-off-by: Alexey Shumkin <Alex.Crezoff@xxxxxxxxx> > >> > Reviewed-by: Johannes Sixt <j.sixt@xxxxxxxxxxxxx> > >> > >> I do not recall this exact patch reviewed by J6t, but perhaps I > >> missed a message on the list? > > I've reread 'SubmittingPatches' doc, and I can say I used "Reviewed-by" > > incorrectly. Sorry for this. It must be "Suggested-by" there, I guess. > > OK, then I'll queue this patch (but not 2-4/5 yet) with log message > amended. Excuse me, you've said "Ok" for 2/5 message, and then explained (as I understood) then "subtle difference" between EOF and \EOF. Should I change the message somehow? > > Thanks. -- Alexey Shumkin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html