Re: [PATCH] clone: Skip pack-*.keep files when cloning locally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jens Lindström <jl@xxxxxxxxx> writes:

> On Mon, Jul 1, 2013 at 6:20 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> I am not sure if we should care that deeply about them in the first
>> place.
>
> Fine by me; I don't really have a strong opinion on the matter.
>
>> Besides, I think you can make a hardlink to a file that you cannot
>> read.
>
> Not always.  The Linux kernel can at least be configured not to allow
> it.  It seems this is enabled by default in at least Debian.

You learn a new thing every day, I guess.  I am on Debian, I do not
think I did any customization in that area, and I can hardlink just
fine.

> This restriction had me a bit confused when I was testing variations
> here; I expected all "access denied" failures to be because of .keep
> files, but in fact creating hardlinks to other files (.idx and .pack)
> failed too, even though they were readable.  

Is it possible that you are tripping cross-device link?  The reason
why we have "attempt to hardlink but fall back to copy" is exactly
because it is fairly common that people try local-cheap clone without
realizing the source and the destination may be on separate filesystems.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]