Re: [PATCH] [submodule] Add depth to submodule update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 28.06.2013 20:44, schrieb Junio C Hamano:
> Heiko Voigt <hvoigt@xxxxxxxxxx> writes:
> 
>> On Thu, Jun 27, 2013 at 04:54:45PM +0200, Jens Lehmann wrote:
>> ...
>>> Me too thinks adding "--depth" to "update" makes sense (and I don't
>>> think that this pretty generic name will become a problem later in
>>> case someone wants to add a maximum recursion depth, as grep already
>>> uses "--max-depth" for the same purpose).
>>
>> Hmm, but does it have a --depth option for revisions? Maybe we should
>> call it --clone-depth or --rev-depth to make it clear? --depth and
>> --max-depth would be completely orthogonal but the name does not allow
>> to distinguish them properly.
> 
> I do not have a strong opinion either way, but as you suggest, it
> might be a good idea to call this new option --clone-depth to be
> more specific.

No strong opinion here either, but I'm leaning towards "--depth"
because on one hand we already have the "--reference" option which
is passed on to the clone command (and not "--clone-reference") and
on the other hand I cannot see the need for yet another depth option
(even my "--max-depth" example doesn't seem to be terribly useful).
But I might be wrong on the last one ;-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]