Hi Junio, I don't think you've picked this up. Are you expecting a
re-roll or did it just get lost in the noise?
On Sat, Jun 22, 2013 at 12:25:17PM +0100, John Keeping wrote:
> git-completion.bash's parsing of the command name relies on everything
> preceding it starting with '-' unless it is the "-c" option. This
> allows users to use the stuck form of "--work-tree=<path>" and
> "--namespace=<path>" but not the unstuck forms "--work-tree <path>" and
> "--namespace <path>". Fix this.
>
> Similarly, the completion only handles the stuck form "--git-dir=<path>"
> and not "--git-dir <path>", so fix this as well.
>
> Signed-off-by: John Keeping <john@xxxxxxxxxxxxx>
> ---
> contrib/completion/git-completion.bash | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 6c3bafe..8fbf941 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2492,9 +2492,10 @@ __git_main ()
> i="${words[c]}"
> case "$i" in
> --git-dir=*) __git_dir="${i#--git-dir=}" ;;
> + --git-dir) ((c++)) ; __git_dir="${words[c]}" ;;
> --bare) __git_dir="." ;;
> --help) command="help"; break ;;
> - -c) c=$((++c)) ;;
> + -c|--work-tree|--namespace) ((c++)) ;;
> -*) ;;
> *) command="$i"; break ;;
> esac
> --
> 1.8.3.1.676.gaae6535
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html