Re: [PATCH v15 04/16] Refactor quote_path_relative, remove unused params

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/6/27 Junio C Hamano <gitster@xxxxxxxxx>:
>> diff --git a/quote.c b/quote.c
>> index 64ff3..ebb8 100644
>
> You seem to be using unusually short abbrev length.
>
> Please don't, at least in format-patch output.
>
> "ebb8" may be unique within your repository, but may not be unique
> in repositories of other people who attempt to apply your patches.
>
> Offtopic.  Fixing this, without forcing you to use the default
> abbrev length everywhere, _might_ require a bit of changes to the
> configuration mechanism, or "git format-patch", or both.  I've also
> seen in some other thread that --numstat was used in addition to the
> usual --stat, which should not be added to format-patch output only
> because the user configured it for other "diff/log" uses, which may
> also need to be fixed in the same way.

Thank you for your notice. I find that I have a setting: core.abbrev=4,
which overrides the default. Maybe I set it two years ago, when I wrote
my book on Git in Chinese.

-- 
Jiang Xin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]