Re: [PATCH v2 05/14] remote: remove dead code in read_branches_file()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:

> -	/*
> -	 * With "slash", e.g. "git fetch jgarzik/netdev-2.6" when
> -	 * reading from $GIT_DIR/branches/jgarzik fetches "HEAD" from
> -	 * the partial URL obtained from the branches file plus
> -	 * "/netdev-2.6" and does not store it in any tracking ref.
> -	 * #branch specifier in the file is ignored.
> -	 *
> -	 * Otherwise, the branches file would have URL and optionally
> -	 * #branch specified.  The "master" (or specified) branch is
> -	 * fetched and stored in the local branch of the same name.
> -	 */

Removal of the second paratraph is wrong, isn't it?

>  	frag = strchr(p, '#');
>  	if (frag) {
>  		*(frag++) = '\0';
>  		strbuf_addf(&branch, "refs/heads/%s", frag);
>  	} else
>  		strbuf_addstr(&branch, "refs/heads/master");
> -	if (!slash) {
> -		strbuf_addf(&branch, ":refs/heads/%s", remote->name);
> -	} else {
> -		strbuf_reset(&branch);
> -		strbuf_addstr(&branch, "HEAD:");
> -	}
> +
> +	strbuf_addf(&branch, ":refs/heads/%s", remote->name);
>  	add_url_alias(remote, p);
>  	add_fetch_refspec(remote, strbuf_detach(&branch, NULL));
>  	/*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]