Am 6/19/2013 8:09, schrieb Ramkumar Ramachandra:
> Johannes Sixt wrote:
>> I haven't followed the topic closely, but I wonder why there are so many
>> explicit assignments to GIT_REFLOG_ACTION. Is calling set_reflog_action
>> (defined in git-sh-setup) the wrong thing to do?
>
> Does this answer your question?
>
> set_reflog_action() {
> if [ -z "${GIT_REFLOG_ACTION:+set}" ]
> then
> GIT_REFLOG_ACTION="$*"
> export GIT_REFLOG_ACTION
> fi
> }
Please don't state the obvious, that does not help. Of course, this does
not answer my question. I was rather hinting that it may be wrong to set
GIT_REFLOG_ACTION explicitly.
I thought that the convention is not to modify GIT_REFLOG_ACTION if it is
already set. set_reflog_action does just that.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html