Re: [PATCH] unpack-trees: don't shift conflicts left and right

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 18.06.2013 01:42, schrieb Junio C Hamano:
But the need to go all the way up in the recursive callframes to get
the union of bitmask to get conflicts looks somewhat ugly.

Yes, that's not pretty. It's like make_traverse_path in that regard, though, so it fits in somehow.

I suspect the *real* solution is to put something like traverse_trees_recursive into tree-walk.c. Both callers of traverse_tree recurse into subdirectories in slightly different ways. Providing that functionality in a central place should reduce code duplication.

René

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]