Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:
> Several callers set GIT_REFLOG_ACTION via set_reflog_action(), but
> nobody unsets it, leaving a potentially stray variable in the
> environment. Fix this by making die_with_status() unset it.
I am totally lost.
- You can set your own environment variables, and they will affect
your child processes' environment, but only _before_ you spawn
them. After you spawn them, changes to your environment will not
affect your child processes' environment.
- There is no mechanism for you to affect environment of your
parent process.
- And we are exiting the process by calling die_with_status.
Whose environment are you trying to affect (or not affect) with this
change? This will not affect your children, this will not affect
your parent, and this will not help you, either.
Puzzled.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
> ---
> git-sh-setup.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index 2f78359..3297103 100644
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -51,6 +51,7 @@ die () {
> }
>
> die_with_status () {
> + export GIT_REFLOG_ACTION=
> status=$1
> shift
> echo >&2 "$*"
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html