send-email adds redundant From: lines to message body

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

'git send-email' recently started to add redundant From: lines to my
messages, see e.g.

  http://article.gmane.org/gmane.comp.version-control.git/228132

Bisect points to:

commit da18759e86bb1a7ee718c79a0c6cb15fbcbdf3c2
Author: Michael S. Tsirkin <mst@xxxxxxxxxx>
Date:   2013-06-05 21:11:00 +0300

    send-email: make --suppress-cc=self sanitize input
    
    --suppress-cc=self fails to filter sender address in many cases where it
    needs to be sanitized in some way, for example quoted:
    "A U. Thor" <author@xxxxxxxxxxx>
    To fix, make send-email sanitize both sender and the address it is
    compared against.
    
    Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
    Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>

The exact commands I run were:

  git format-patch --cover-letter --subject-prefix='PATCH v2' 2847cae835fa70f00e6e2286fbfa5595cb2247d0..bash-prompt-speedup
  vim 0000-cover-letter.patch
  git send-email --to=git@xxxxxxxxxxxxxxx 00*

i.e. no '--suppress-cc=self' option at all.  Values of related config
variables are:

  git config --get-regexp '(sendemail|user)\..*'
  sendemail.smtpserver /usr/local/bin/putmail
  sendemail.confirm auto
  user.name SZEDER Gábor
  user.email szeder@xxxxxxxxxx

The 'á' in my first name is apparently significant: creating a commit
and sending it as a patch with that accent removed doesn't trigger a
redundant From: line.


Thanks,
Gábor

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]