Re: [PATCH] git-remote-mediawiki: remove hardcoded version number in the test suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



benoit.person@xxxxxxxxxx writes:

> Updates the code to make it more easy to switch mediawiki version when
> testing. Before that, the version number was partly hardcoded, partly
> in a var.

This is obviously good.

> Maybe I should add a warning that the installation procedure may not work 
> in the future ? It seems to work for the range 1.19.X - 1.21.X though :) ?
> Should I also update the version number to the latest one (1.21.1) ?

This kind of remarks does not belong to the commit message, it should be
below the --- (before the diffstat).

And yes, I think a comment saying "# Versions foo, bar and boz have been
tested" or so would be welcome.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]