On Wed, Jun 12, 2013 at 3:02 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> ... Alas, this >> simple solution reject on the basis that we shouldn't organize the >> code, because the code is not meant to be organized. > > The proposed patch was rejected on the basis that it was organized > the code in a wrong way. And your patch shows how it should be > done. In your opinion. The fact that nobody outside of 'git' will ever use init_copy_notes_for_rewrite() still remains. Therefore this "organization" is wrong. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html