Junio C Hamano <gitster@xxxxxxxxx> writes: > Célestin Matte <celestin.matte@xxxxxxxxxx> writes: > >> Subroutines' parameters should be affected to variable before doing anything >> else >> Besides, existing instruction affected a variable inside a "if", which break >> Git's coding style > > I think s/affect/assign/g is what you meant. Yes, common false friends for French people ;-). > my ($namespace) = @_; > my $namespace = shift; > > My impression has been that both are equally common, The second is the most common in git-remote-mediawiki (but I don't have any preference nor know what is recommended elsewhere). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html