Re: [PATCH v4 2/2] status:introduce status.branch to enable --branch by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jorge-Juan.Garcia-Garcia@xxxxxxxxxxxxxxx writes:

> +test_expect_success '"status.branch=true" different from "--no-branch"' '
> +	git -c status.branch=true status -s >actual &&
> +	git status -s --no-branch  >expected_nobranch &&

Two nitpicks:

There are two spaces before >, there should be one.

If the first "git" command fails, then you fail to create
expected_nobranch and the other tests fail too. Creating
expected_nobranch before actual would solve this. You have the same
issue in PATCH 1/2.

With or without these fixed,

Reviewed-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx>

(both patches)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]