Richard Hartmann <richih.mailinglist@xxxxxxxxx> writes:
> Spawning a new subprocess for every line printed is inefficient.
> Thus spawn only one instance of `echo`.
>
> Signed-off-by: Richard Hartmann <richih.mailinglist@xxxxxxxxx>
> ---
> templates/hooks--pre-commit.sample | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/templates/hooks--pre-commit.sample b/templates/hooks--pre-commit.sample
> index 18c4829..126ae13 100755
> --- a/templates/hooks--pre-commit.sample
> +++ b/templates/hooks--pre-commit.sample
> @@ -31,18 +31,18 @@ if [ "$allownonascii" != "true" ] &&
> test $(git diff --cached --name-only --diff-filter=A -z $against |
> LC_ALL=C tr -d '[ -~]\0' | wc -c) != 0
> then
> - echo "Error: Attempt to add a non-ascii file name."
> - echo
> - echo "This can cause problems if you want to work"
> - echo "with people on other platforms."
> - echo
> - echo "To be portable it is advisable to rename the file ..."
> - echo
> - echo "If you know what you are doing you can disable this"
> - echo "check using:"
> - echo
> - echo " git config hooks.allownonascii true"
> - echo
> + echo 'Error: Attempt to add a non-ascii file name.
> +
> +This can cause problems if you want to work
> +with people on other platforms.
> +
> +To be portable it is advisable to rename the file.
> +
> +If you know what you are doing you can disable this
> +check using:
> +
> + git config hooks.allownonascii true
> +'
> exit 1
> fi
Thanks.
Writing it as a single here-text
cat <<-EOF
Error: Attempt to...
the message body that is
multi-line
EOF
might make it easier for people who want to activate and customize
the message, but honestly this is a borderline "Meh" at least to me.
Will take a look at other patches first before further commenting on
this.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html