From: "Felipe Contreras" <felipe.contreras@xxxxxxxxx>
Sent: Sunday, June 09, 2013 6:23 PM
On Sun, Jun 9, 2013 at 12:18 PM, SZEDER Gábor <szeder@xxxxxxxxxx>
wrote:
On Sun, Jun 09, 2013 at 11:40:22AM -0500, Felipe Contreras wrote:
We should free objects before leaving.
Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
A shortlog-friendlier subject could be: "sequencer: free objects
before leaving".
I already defended my rationale for this succinct commit message:
http://thread.gmane.org/gmane.comp.version-control.git/225609/focus=225610
--
Felipe Contreras
I think I'd prefer a mixture of both.
"sequencer: trivial fix: free objects before leaving".
This gives the best of both worlds in that the 'triviality' is plainly
there to see, and so is the type of triviality, just in case it has some
un-noticed side effect that someone is looking for at a leter date
Same goes for "build: trivial cleanup: don't repeat prerequisites"
[PATCH v4 03/45]
All the best,
Philip
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html