On Sun, Jun 9, 2013 at 2:25 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> The function is made to use with free_pathspec() because a simple
> struct assignment is not enough (free_pathspec wants to free "items"
> pointer).
I had to read this about five or six times before I could parse and
understand it. Perhaps rewrite something like this:
free_pathspec() frees pathspec->items, hence simple struct
assignment does not properly duplicate a pathspec. Introduce
copy_pathspec() to clone a pathspec correctly by deeply copying
the items member.
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html