Célestin Matte <celestin.matte@xxxxxxxxxx> writes: > In Perl, '\n' is not a newline, but instead a literal backslash followed by an > "n". As the output of "rev-list --first-parent" is line-oriented, what we want > here is a newline. This is right, but the code actually worked the way it was. I'm not sure, but my understanding is that '\n' is the string "backslash followed by n", but interpreted as a regexp, it is a newline. The new code looks better than the old one, but the log message may be improved. In any case, Acked-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html