On Sat, Jun 8, 2013 at 4:04 PM, Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote: > Felipe Contreras wrote: >>> Ofcourse they're implementation details. Even in this very test, I >>> check $dotest/autostash plenty of times. >> >> The more the test relies on implementation details, the worst. > > I'm not convinced about this. My understanding of these tests is that they make sure new/better implementations don't break the user experience/defined behavior. If the test relies on the implementation, then they lose most of their interest. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html