Re: [PATCH] t0070: Use precondition CANNOTWRITE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 08.06.2013 08:51, schrieb Torsten Bögershausen:
> Filesystems like VFAT or NTFS allow to create files regardless of
> the write permissions of the directory.
> 
> Therefore "mktemp to unwritable directory" in t0700 will always fail on
> Windows using NTFS.
> This TC has been disabled for MINGW, and needs to be disabled for CYGWIN.
> 
> Use the precondition CANNOTWRITE which is probing the file system and
> works for MINGW, CYGWIN and even for Linux using VFAT.

Shouldn't it be a matter of

-test_expect_success POSIXPERM 'mktemp to unwritable directory prints filename' '
+test_expect_success SANITY 'mktemp to unwritable directory prints filename' '

It probably wouldn't catch Linux VFAT, but there're already a lot of
tests that don't pass on Linux VFAT.

-- Hannes

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]