On Fri, Jun 07, 2013 at 02:25:54PM -0500, Felipe Contreras wrote: > On Fri, Jun 7, 2013 at 2:09 PM, Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote: > > 77c130 (completion: clarify ls-tree, archive, show completion, > > 2013-06-02) removed __git_complete_file () because it had no callers > > left in the file. However, to avoid breaking user scripts that may > > depend on this, add it back as a deprecated alias. > > This is fine by me, but at some point we need to decide how we should > prefix the functions that are supposed to be used by external scripts. Or rather how we should prefix the functions that are _not_ supposed to be used by external scripts. That way all public functions would retain the "__git" prefix and existing scripts calling only common functions like __git_(heads|git_refs|find_on_cmdline|etc.) would work without modification. Best, Gábor -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html