Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
<celestin.matte@xxxxxxxxxx> wrote:
> Signed-off-by: Célestin Matte <celestin.matte@xxxxxxxxxx>
> Signed-off-by: Matthieu Moy <matthieu.moy@xxxxxxxxxxxxxxx>
> ---
>  contrib/mw-to-git/git-remote-mediawiki.perl |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
> index ae6dd2e..1c34ada 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-mediawiki.perl
> @@ -22,7 +22,6 @@ binmode STDERR, ":encoding(UTF-8)";
>  binmode STDOUT, ":encoding(UTF-8)";
>
>  use URI::Escape;
> -use IPC::Open2;
>  use Readonly;
>
>  # Mediawiki filenames can contain forward slashes. This variable decides by which pattern they should be replaced
> @@ -338,7 +337,8 @@ sub get_mw_pages {
>  sub run_git {
>         my $args = shift;
>         my $encoding = (shift || "encoding(UTF-8)");
> -       open(my $git, "-|:$encoding", "git " . $args);
> +       open(my $git, "-|:$encoding", "git " . $args)
> +           or die "Unable to open: $!\n";
>         my $res = do {
>                 local $/ = undef;
>                 <$git>

These two changes are unrelated and could be split into distinct
patches (IMHO, though others may disagree).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]