On Fri, Jun 7, 2013 at 5:40 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >>> Perhaps like this? >>> >>> Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Makefile b/Makefile >>> index a748133..03fda50 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -2239,6 +2239,7 @@ endif >>> >>> test_bindir_programs := $(patsubst %,bin-wrappers/%,$(BINDIR_PROGRAMS_NEED_X) $(BINDIR_PROGRAMS_NO_X) $(TEST_PROGRAMS_NEED_X)) >>> >>> +all:: $(NO_INSTALL) >>> all:: $(TEST_PROGRAMS) $(test_bindir_programs) >>> >>> bin-wrappers/%: wrap-for-bin.sh >>> @@ -2489,7 +2490,7 @@ clean: profile-clean coverage-clean >>> $(RM) *.o *.res block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o vcs-svn/*.o \ >>> builtin/*.o $(LIB_FILE) $(XDIFF_LIB) $(VCSSVN_LIB) >>> $(RM) $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) git$X >>> - $(RM) $(TEST_PROGRAMS) >>> + $(RM) $(TEST_PROGRAMS) $(NO_INSTALL) >>> $(RM) -r bin-wrappers $(dep_dirs) >>> $(RM) -r po/build/ >>> $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope* >> >> Looks good to me. > > Actually the above would not work well. This is because... > >>> ..., assuming that NO_INSTALL will mean "We always >>> want to build these, but we never do not want to install them" >>> forever (which I am OK to assume). > > ... the assumption does *not* hold already with git-remote-testgit, > which is (or will be with patch 2/2) NO_INSTALL and we do not want > to install it, but it is not built, hence we do not want to remove > it, either. It is generated, in next. If it's not generated, there's no need to add it to NO_INSTALL. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html