Hi, This series of commits intends to follow most of perlcritic's recommandations in order to make the code more maintainable and readable. I followed most recommandations from level 5 (most critical ones )to 2, but left a great part of the level 1 ones, as they were more about personal choices of coding style and less about actually improving maintainability and preventing bugs. Among those I did *not* take into account were: - ValuesAndExpressions::ProhibitNoisyQuotes: use q(*) instead of '*' for quoting some characters - RegularExpressions::ProhibitEnumeratedClasses: e.g., use [0-9] instead of \d - CodeLayout::ProhibitParensWithBuiltins: don't use parentheses with builtin functions - RegularExpressions::RequireExtendedFormatting, RegularExpressions::RequireDotMatchAnything and RegularExpressions::RequireLineBoundaryMatching: use s, m and x flags for *every* regexp - and some others. Run perlcritic -1 on patched file to so what is left. Please tell me if you think some of them should be applied anyway. On the other hand, if quite not sure of the relevance of some commits: - Add newline in the end of die() error messages [3/18]: are die() messages correctly handled already? - Place the open() call inside the do{} struct and prevent failing close [17/18]: current code fails to close the filehandle (try adding a "or warn(..)" after the close() to check this). However, perlcritic complains as well if you don't put an explicit close(), which fails when you put it. I'm not sure of what's happening and what's the best solution for this. I checked Documentation/CodingGuidelines and none of these modifications should contradict it. This is my first patch, so don't hesitate to point to me anything wrong with it. Célestin Matte (18): Follow perlcritic's recommendations - level 5 and 4 Change style of some regular expressions to make them clearer Add newline in the end of die() error messages Prevent local variable $url to have the same name as a global variable Turn double-negated expressions into simple expressions Remove unused variable Rename a variable ($last) so that it does not have the name of a keyword Explicitely assign local variable as undef and make a proper one-instruction-by-line indentation Check return value of open and remove import of unused open2 Put long code into a submodule Modify strings for a better coding-style Brace file handles for print for more clarity Remove "unless" statements and replace them by negated "if" statements Don't use quotes for empty strings Put non-trivial numeric values (e.g., different from 0, 1 and 2) in constants. Fix a typo ("mediwiki" instead of "mediawiki") Place the open() call inside the do{} struct and prevent failing close Clearly rewrite double dereference contrib/mw-to-git/git-remote-mediawiki.perl | 558 ++++++++++++++------------- 1 file changed, 298 insertions(+), 260 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html