Re: [PATCH] t/README: test_must_fail is for testing Git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Junio C Hamano" <gitster@xxxxxxxxx>
Sent: Tuesday, June 04, 2013 9:49 PM
"Philip Oakley" <philipoakley@xxxxxxx> writes:

From: "Junio C Hamano" <gitster@xxxxxxxxx>
Sent: Tuesday, June 04, 2013 5:50 PM
When a test wants to make sure there is no <string> in an output
file, we should just say "! grep string output";

Small nit: It took me two readings of the commit message to correctly
parse this break point. The flowing together of the two parts with the
semicolon fooled me. Separate them?

     "test_must_fail"
is there only to test Git command and catch unusual deaths we know
about (e.g. segv) as an error, not as an expected failure.

Thanks.  Does this read better?

Yes.  Thanks.


   t/README: test_must_fail is for testing Git

   When a test wants to make sure there is no <string> in an output
   file, we should just say "! grep string output".

"test_must_fail" is there only to test Git command and catch unusual
   deaths we know about (e.g. segv) as an error, not as an expected
   failure.  "test_must_fail grep string output" is unnecessary, as
   we are not making sure the system binaries do not dump core or
   anything like that.

   Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
--

Philip
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]