Junio C Hamano <gitster@xxxxxxxxx> writes:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>
>> +static void run_rewrite_hook(void)
>> +{
>> + struct strbuf buf = STRBUF_INIT;
>> + struct child_process proc;
>> + const char *argv[3];
>> + int code, i;
>> +
>> + argv[0] = find_hook("post-rewrite");
>> + if (!argv[0])
>> + return;
>> +
>> + argv[1] = "rebase";
>> + argv[2] = NULL;
>
> When the end-user action is "git cherry-pick A..B", shouldn't
> the rewrite hook be called with "cherry-pick" not "rebase" as its
> first argument?
The whole function was copied from builtin/commit.c except for that
string. So it should be refactored anyway, with the "cherry-pick" being
an argument.
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html