Sparse issues an "'object_array_slopbuf' not declared. Should it be static?" warning. In order to suppress the warning, since this symbol does not need more than file visibility, we simply add the static modifier to its declaration. Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> --- Hi Michael, If you need to re-roll the patches in your 'mh/reflife' branch, could you please squash this into the patch corresponding to commit cbdeb23e ("object_array_entry: fix memory handling of the name field", 25-05-2013). Thanks! ATB, Ramsay Jones object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/object.c b/object.c index 2976b2e..0de4c91 100644 --- a/object.c +++ b/object.c @@ -269,7 +269,7 @@ int object_list_contains(struct object_list *list, struct object *obj) * A zero-length string to which object_array_entry::name can be * initialized without requiring a malloc/free. */ -char object_array_slopbuf[1]; +static char object_array_slopbuf[1]; static void add_object_array_with_mode_context(struct object *obj, const char *name, struct object_array *array, -- 1.8.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html