On 05/29/2013 10:21 AM, Thomas Rast wrote:
> Michael Haggerty <mhagger@xxxxxxxxxxxx> writes:
>
>> Since string_list_add_one_ref() adds refname to the string list, but
>> the lifetime of refname is limited, it is important that the
>> string_list passed to string_list_add_one_ref() has strdup_strings
>> set. Document this fact.
>>
>> All current callers do the right thing.
> [...]
>> +/*
>> + * The list argument must have strdup_strings set on it.
>> + */
>> void string_list_add_refs_by_glob(struct string_list *list, const char *glob)
>> {
>> if (has_glob_specials(glob)) {
>
> Maybe add an assert() so that this is bulletproof?
Good idea. Will be added in v3.
Michael
--
Michael Haggerty
mhagger@xxxxxxxxxxxx
http://softwareswirl.blogspot.com/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html