Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Junio C Hamano wrote: >>> case PUSH_DEFAULT_CURRENT: >>> + if (!branch) >>> + die(_(message_detached_head_die), remote->name); >>> add_refspec("HEAD"); >>> break; >> >> Would it hurt to do >> >> if (!branch_get(NULL)) >> die(...); >> >> here, without the first hunk? > > And how would I change the add_refspec() call to take branch->name in [3/3]? By doing something like this, perhaps? struct ... branch; switch (...) { ... case it-only-matters-here: branch = branch_get(NULL); if (!branch) die(...); } -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html