Junio C Hamano wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > > > Junio C Hamano wrote: > >> * fc/makefile (2013-05-26) 5 commits > >> - build: do not install git-remote-testpy > >> - build: add NO_INSTALL variable > >> - build: cleanup using $< > >> - build: cleanup using $^ > >> - build: trivial simplification > >> (this branch is used by fc/remote-helpers-use-specified-python.) > > > > No, these are independent. > > By the way, I dropped the order-only one and I explained my > reasoning for doing so, but I haven't heard back from you. > > As I haven't used the order-only dependencies nor '|' myself so far > (primarily because I have not seen a case where it was needed), it > would have been nice if you responded with either "yes, this is not > order-only and the patch should be dropped", or "no, order-only is > correct because...". I'm not sure, so I think it's OK to drop it. I've used order-only to dependencies that should not be listed when doing $^ which doesn't affect us anyway, so I thought it was more descriptive with the patch, but I can see why it would break the build if that file is updated and the targets that depend on it don't. I don't have time to investigate further, so I think it's OK. > In any case, I think the above remaining five were sensible changes, > and am thinking about having it graduating early in the cycle. If you do that, please add git-remote-testgit.sh to the NO_INSTALL list. I didn't do that at the time because I was working on the master branch, but this changed in 'next'. > I somehow had an impression that the other series depended on this > for SCRIPT_PYTHON_* stuff, but this is about the installation step > and the other one is primarily about the build step, so in that > sense it may be independent. They are completely independent. The improvments to the main Makefile is what I came up while trying to understand the code. > >> * fc/remote-bzr (2013-05-28) 8 commits > >> - remote-bzr: add fallback check for a partial clone > >> - remote-bzr: reorganize the way 'wanted' works > >> - remote-bzr: trivial cleanups > >> - remote-bzr: change global repo > >> - remote-bzr: delay cloning/pulling > >> - remote-bzr: simplify get_remote_branch() > >> - remote-bzr: fix for files with spaces > >> - remote-bzr: recover from failed clones > >> > >> The ones near the tip conflicted with the hotfix for 1.8.3 so I > >> discarded them for now. > >> > >> Will merge to 'next'? > > > > Didn't I resend these with the conflict fixed? > > As the date above (05-28) shows, it seems that I did not forget to > drop the old one to replace with the new one, but I did forget to > remove the stale comment from the previous issue. Thanks for > noticing. Oh, I see. Cool. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html