On Wed, May 29, 2013 at 12:33 AM, Martin von Zweigbergk <martinvonz@xxxxxxxxx> wrote: > As Junio asked in the previous iteration, shouldn't this have been in > the first patch? No, the first patch is splitting the code without introducing any functional changes. This is fixing a bug that already exists, we could fix it before the split, or after, but mixing the split and the fix at the same time is a no-no. One change splits, the other change fixes, what's wrong with that? This way it's easy to see what each patch does. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html