Re: [PATCH v4 14/21] remote-hg: show more proper errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Felipe,
I know that has been integrated a while ago.

On Thu, Apr 11, 2013 at 2:23 PM, Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
> When cloning or pushing fails, we don't want to show a stack-trace.
>
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index ff89725..3ae3598 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -284,11 +284,17 @@ def get_repo(url, alias):
>      else:
>          local_path = os.path.join(dirname, 'clone')
>          if not os.path.exists(local_path):
> -            peer, dstpeer = hg.clone(myui, {}, url, local_path, update=False, pull=True)
> +            try:
> +                peer, dstpeer = hg.clone(myui, {}, url, local_path, update=True, pull=True)
> +            except:
> +                die('Repository error')
>              repo = dstpeer.local()

Can you explain why "update" went from False to True ? That can be a
problem if the repository is BIG (two working directories instead of
one can raise space issues).

The commit message is not so helpful here ;)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]