Linus Torvalds <torvalds@xxxxxxxx> writes: > On Sun, 21 Jan 2007, Junio C Hamano wrote: >> >> I've been annoyed by those scary messages fsck-objects enough >> and was wondering if we could make it less scary. Especially >> annoying is that the message about missing blobs and trees that >> are only referred to by dangling commits. > ... > Add my sign-off on the patch as appropriate. I do think it's mergeable, > but I'd _really_ like somebody else to double-check me here. I think this is very sensible. Even without all the added comments, the refactoring makes the code much more readable. -- >8 -- From: Linus Torvalds <torvalds@xxxxxxxx> Date: Sun, 21 Jan 2007 22:26:41 -0800 (PST) Subject: [PATCH] fsck-objects: refactor checking for connectivity This separates the connectivity check into separate codepaths, one for reachable objects and the other for unreachable ones, while adding a lot of comments to explain what is going on. When checking an unreachable object, unlike a reachable one, we do not have to complain if it does not exist (we used to complain about a missing blob even when the only thing that references it is a tree that is dangling). Also we do not have to check and complain about objects that are referenced by an unreachable object. This makes the messages from fsck-objects a lot less noisy and more useful. Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx> Signed-off-by: Junio C Hamano <junkio@xxxxxxx> --- <<your patch here>> - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html