On Fri, May 24, 2013 at 4:19 PM, Ramkumar Ramachandra
<artagnon@xxxxxxxxx> wrote:
> @@ -928,12 +936,22 @@ static void emit(const char *cp, const char *ep)
> static void show_ref(struct refinfo *info, const char *format, int quote_style)
> {
> const char *cp, *sp, *ep;
> + char color[COLOR_MAXLEN];
>
> for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) {
> ep = strchr(sp, ')');
> if (cp < sp)
> emit(cp, sp);
> - print_value(info, parse_atom(sp + 2, ep), quote_style);
> +
> + /* Do we have a color specification? */
> + if (!prefixcmp(sp, "%C("))
> + color_parse_mem(sp + 3,
> + ep - sp - 3,
> + "--format ", color);
> + else {
> + printf("%s", color);
Is it not possible for "color" to be used uninitialized here ?
> + print_value(info, parse_atom(sp + 2, ep), quote_style);
> + }
> }
> if (*cp) {
> sp = cp + strlen(cp);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html