On 05/21/2013 07:27 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@xxxxxxxxxxxx> writes:
>
>> Instead of accepting an array and using exactly two elements from the
>> array, take two single (struct object_array_entry *) arguments.
>>
>> Signed-off-by: Michael Haggerty <mhagger@xxxxxxxxxxxx>
>> ---
>> builtin/diff.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/builtin/diff.c b/builtin/diff.c
>> index 8c2af6c..ba68c6c 100644
>> --- a/builtin/diff.c
>> +++ b/builtin/diff.c
>> @@ -153,7 +153,8 @@ static int builtin_diff_index(struct rev_info *revs,
>>
>> static int builtin_diff_tree(struct rev_info *revs,
>> int argc, const char **argv,
>> - struct object_array_entry *ent)
>> + struct object_array_entry *ent0,
>> + struct object_array_entry *ent1)
>> {
>> const unsigned char *(sha1[2]);
>> int swap = 0;
>> @@ -161,13 +162,13 @@ static int builtin_diff_tree(struct rev_info *revs,
>> if (argc > 1)
>> usage(builtin_diff_usage);
>>
>> - /* We saw two trees, ent[0] and ent[1].
>> - * if ent[1] is uninteresting, they are swapped
>> + /* We saw two trees, ent0 and ent1.
>> + * if ent1 is uninteresting, they are swapped
>> */
>
> "While you are touching this comment" is a perfect time to fix the
> existing style violation.
Yes. Will fix in next version.
Michael
--
Michael Haggerty
mhagger@xxxxxxxxxxxx
http://softwareswirl.blogspot.com/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html