On Tue, May 21, 2013 at 7:20 PM, SZEDER Gábor <szeder@xxxxxxxxxx> wrote: > On Tue, May 21, 2013 at 07:03:09PM -0500, Felipe Contreras wrote: >> On Tue, May 21, 2013 at 6:36 PM, SZEDER Gábor <szeder@xxxxxxxxxx> wrote: >> > On Tue, May 21, 2013 at 06:04:35PM -0500, Felipe Contreras wrote: >> >> On Tue, May 21, 2013 at 5:41 PM, SZEDER Gábor <szeder@xxxxxxxxxx> wrote: >> >> >> >> > On Tue, May 21, 2013 at 10:54:27PM +0200, Thomas Gummerer wrote: >> >> >> Currently the __git_ps1 git prompt gives the following error with a >> >> >> repository converted by git-svn, when used with zsh: >> >> >> >> >> >> __git_ps1_show_upstream:19: bad pattern: svn_remote[ >> >> >> >> >> >> This was introduced by 6d158cba (bash completion: Support "divergence >> >> >> from upstream" messages in __git_ps1), when the script was for bash >> >> >> only. Make it compatible with zsh. >> >> > >> >> > What is the actual cause of this problem/incompatibility and how/why do >> >> > these changes fix it? >> >> >> >> I think the commit message makes that very clear. >> > >> > If that were the case I wouldn't have asked in the first place. >> >> You are not the authority on what *I think*, or if you meant s/If that >> were the case/If the message was clear/, still; you are not the >> authority on what is or is not true. Only on what is your opinion. > > I would have preferred a more constructive reply, perhaps with answers > to the questions I asked earlier... That's the job of the patch submitter, all I did was express my option about the commit message. You have no say as to what is my option. You are the one not being constructive by claiming that all opinions contrary to yours are wrong. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html