Felipe Contreras wrote: >> Will $2 ever be nil (from fmt_person)? ie. Why are you checking for >> the special case " <\S+?>$"? > > Yes, '<email>' was valid in earlier versions of git. There's a non-optional space before the "<email>" in your regex, which is what I was pointing out. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html