Junio C Hamano <gitster@xxxxxxxxx> writes:
> Also please fix this one:
>
>> + for_each_string_list_item(item, (struct string_list *)stuff->stuff) {
>> + if ((*chosen)[i] < 0)
>> + (*chosen)[i] = 0;
>> + strbuf_addf(&menu, "%s%2d: %s", (*chosen)[i] ? "*" : " ", ++i, item->string);
>
> Because the evaluation order of function arguments are not defined
> (not left to right; these are comma-expressions),
I cannot spell, sorry. s/are not defined/is not defined/. Also
s/these are c/these are not c/;
>
> (*chosen)[i] ? "*" : " "
>
> may use the original value of "i", or value after increment the
> evaluation of
>
> ++i
>
> left in "i".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html