Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Junio C Hamano wrote: >> - The error message store_stash() gives should not be hardcoded in >> that function. >> >> Save-stash may want to keep saying 'the current status' as it >> said before, but a caller like your rebase-autostash will not be >> saving the "current" status and would want to have a different >> message. > > Makes sense. I think it is fine to have a "default" message to be used when store_stash shell function is not given an optional error message. The command line for it may become: git stash store [-m <message>] [-e <error message>] $stash_sha1 or something like that. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html